Here's a patch for stable: http://github.com/chriseppstein/haml/commit/7512dbe0938da2cc5e0dd083bc9ffea02c0fb79a
Stable and master have diverged significantly in the area of change, so you'll also need to pull the original changeset onto master. FYI: the stable fix changed the CSS output format to compact because I guess the sass plugin options and engine options are different on stable. If that's undesired, I'd ask you to change my fix so that it preserves the existing behavior because I don't see how to resolve the incompatibility. Regarding the :sass filter: I can imagine that we could set an option that preserves backwards compatibility but can be easily turned off for the correct behavior. Or we could break backwards compatibility on master and document that change for the next release. Or we could issue a deprecation warning for one release and then break backwards compatibility one release later... In other words, I don't see any reason to not proceed forward in making the framework better just because we have users. Chris On Sep 3, 2:00 pm, Nathan Weizenbaum <[EMAIL PROTECTED]> wrote: > Chris Eppstein wrote: > > I've customized the template locations in my environment and my > > @import directives don't work in a sass filter. Here's a changeset > > that doesn't break any tests, but I'm not sure if it's the correct > > behavior in a Non-plugin use case (e.g. command line) > > >http://github.com/chriseppstein/haml/commit/4e99b346dc7fd491aaf0496a3... > > Could you rebase that commit onto stable? It seems like something that > would be useful to have in both branches.> Also, does anyone else find it > strange that the :sass filter doesn't > > emit a <style> tag, but the :javascript filter emits <script> tag. > > The :sass filter was created long before the :javascript filter, when > none of the other filters automatically generated wrapper tags (mostly > because it wouldn't make sense to do so). Although now it would probably > be nicer to have the tags, it would break backwards-compatibility so we > can't really change it. > > - Nathan --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Haml" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/haml?hl=en -~----------~----~----~----~------~----~------~--~---
