Yes, the patch did go into 2.0.3, but not all warnings were removed. I consider uninitialized instance variables defaulting to nil a feature, especially since it turned out that some of the fixes (in particular for @haml_buffer) required a large amount of additional code and a small runtime speed cost.
plambert wrote: > Were these changes included in the 2.0.3 gem? > > If so, I'm still seeing warnings: > > .../lib/ruby/gems/1.8/gems/haml-2.0.3/lib/haml/precompiler.rb:254: > warning: instance variable @multiline not initialized > .../lib/ruby/gems/1.8/gems/haml-2.0.3/lib/haml/engine.rb:142: warning: > instance variable @haml_buffer not initialized > > If not, will they be in a future release? I don't want to patch > locally, if I don't have to. > > Paul > > > On Aug 29, 11:31 pm, Nathan Weizenbaum <[EMAIL PROTECTED]> wrote: > >> Pushed, thanks! >> >> Mislav Marohnić wrote: >> >>> Hello, the attached patch is my take on getting rid of Rubywarnings >>> when run with "ruby -w" or RUBYOPT="-w" environment variable. >>> >>> The hardestwarningsto fix were about @haml_buffer instance variable >>> not being initialized---they were also the most numerous. >>> >>> These commits rely on my previous patch (RedCloth thread); conflicts >>> in engine_test.rb *will* occur if applied without RedCloth fixes. >>> >>> Even with this patch, there *may* be somewarningsabout methods being >>> redefined. Also, some templates in test/haml/templates/ still generate >>> warnings, but with good purpose, and I didn't change that. They should >>> be ignored. >>> >>> Thanks, >>> >>> # Mislav >>> > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Haml" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/haml?hl=en -~----------~----~----~----~------~----~------~--~---
