On Mon, 5 Oct 2009, Willy Tarreau wrote:
On Mon, Oct 05, 2009 at 12:51:07AM +0200, Krzysztof Oledzki wrote:
Non ascii or HTML control characters are masked.
I don't see the reason for masking HTML characters, since the output
is sent over syslog. I'm OK for masking non-ascii characters however.
Because the output is presented on html page - it is added to a popup
generated by "td title". But you are right - we should also add it to
syslog.
I'd prefer that we correctly encode at the destination, which means
to do this in the html stats functions. If necessary I can write an
HTML encoder which would take two chunks for instance.
Sure, it would be great.
Feature can be disabled by defining HCHK_DESC_LEN to 0.
What could be the reason for disabling this feature ? After
all, if people enable log-health-checks, it means they want
more verbose info.
To save HCHK_DESC_LEN==128 bytes for each server. If you found it
unnecessary I'm more than happy to remove this check.
I don't care much about a proxy or a server size. I don't like to
waste, but overall it does not change much the memory usage. Even
large configs with 1000 servers will still only be hit by 128 kB.
You can bet that those running 1000 servers are not counting their
RAM in kilobytes ;-)
What I care about however, is that most of the "hot" struct members
are grouped so that they remain hot in the CPU caches. The other
important thing is to avoid increasing the session size.
Yes, I noticed you moved the place where the counters structuers are
located. Next time I'll try to play with pahole from DWARF2 to find a
better location for new variables. ;)
Best regards,
Krzysztof Olędzki
