Hello Rauf,

On Tue, Dec 28, 2010 at 11:45:03PM +0400, Rauf Kuliyev wrote:
> Hello,
> 
> I have written a small patch to enable a correct PostgreSQL health check in
> 1.4.
> You can grab it here: http://www.kuliyev.com/patch-haproxy
> It works similar to mysql-check with the very same parameters.

Your patch looks fine, except there's a bug here, it reuses a flag
which is already in use two lines below :

 #define PR_O2_LDAP_CHK  0x00400000      /* use LDAP check for server health */
+#define PR_O2_PGSQL_CHK 0x00800000      /* use PGSQL check for server health */
 
 #define PR_O2_EXP_NONE  0x00000000      /* http-check : no expect rule */
 #define PR_O2_EXP_STS   0x00800000      /* http-check expect status */

Also, please consider adding an entry in the doc (you can derive it from
the mysql check), and I'll merge it into 1.5.

Thanks!
Willy


Reply via email to