Hi, On 13 February 2013 08:11, Willy Tarreau <w...@1wt.eu> wrote:
> Hi Marc-Antoine, > > On Tue, Feb 12, 2013 at 10:53:54AM +0100, Marc-Antoine Perennou wrote: > > +systemd/haproxy.service: contrib/systemd/haproxy.service.in > > + mkdir -p systemd > > + sed -e 's:@SBINDIR@:'$(strip $(SBINDIR))':' $< > $@ > > + > > I'm a bit worried with this one, because it will create a new systemd > directory in everyone's sources, which is even not cleaned afterwards. > I'd rather keep the usual behaviour we have with whatever lies in the > contrib subdir, which consists in considering them as add-ons and > leaving them completely in that directory. In my opinion you should > create a simple makefile there so that the packager may just run > "make -C contrib/systemd" to build it and have the result in the > contrib/systemd directory. > > Sure, will do > > diff --git a/contrib/systemd/haproxy.service.in b/contrib/systemd/ > haproxy.service.in > > new file mode 100644 > > index 0000000..f925651 > > --- /dev/null > > +++ b/contrib/systemd/haproxy.service.in > > @@ -0,0 +1,11 @@ > > +[Unit] > > +Description=HAProxy Load Balancer > > +After=network.target > > + > > +[Service] > > +ExecStart=@SBINDIR@/haproxy-systemd-wrapper -f > /etc/haproxy/haproxy.cfg -p /run/haproxy.pid > > +ExecReload=/usr/bin/kill -USR2 $MAINPID > > You should be careful here. On my distro, "kill" is in /bin, not in > /usr/bin. I don't know if it's standard to have it in /usr/bin on > distros which involve systemd, but at first glance it might not be > very much portable. Oh and BTW my distro seems to be right about it, > so please double-check : > > http://refspecs.linuxfoundation.org/FHS_2.3/fhs-2.3.html > > Regards, > Willy > > My bad, /bin is actually a symlink to /usr/bin on my system, but you're right it should be /bin, not /usr/bin, will fix it
