On Wed, May 01, 2013 at 05:49:20PM +0900, Simon Horman wrote:
> On Wed, May 01, 2013 at 10:15:00AM +0200, Willy Tarreau wrote:
> > Hi Keith,
> > 
> > On Tue, Apr 30, 2013 at 09:39:12AM +0000, keith anderson wrote:
> > > Benjamin Polidore <polidore@...> writes:
> > > 
> > > > 
> > > > 
> > > > sorry, this is 1.5 dev 14. 
> > > > 
> > > > thanks.On Wed, Dec 5, 2012 at 9:17 AM, Benjamin Polidore
> > > <polid...@gmail.com> wrote:
> > > > src/proxy.c:46: error: initializer element is not constant
> > > > 
> > > > 
> > > > 
> > > > 
> > > > 
> > > > 
> > > 
> > > Hi Willy,
> > > 
> > > It seems that this issue has crept into the latest haproxy-1.5-dev18 
> > > release.
> > 
> > indeed :-(
> > 
> > I'm CCing Simon and Marc-Antoine who last included stdbool. We fixed this
> > already in the past, so I have now added a notice about this in the readme.
> 
> Sorry about that.

You don't have to be sorry Simon, we discover lots of surprizes when porting
to other OSes, such as Solaris' implementation of isalnum() etc... as macros
that don't work as expected on chars, or AIX using unsigned chars by default
leading to funny behaviour where that was not expected. This is annoying at
first but in the end it teaches us how to write more portable code.

> Is the implication that bool, true and false shouldn't be used in haproxy?

Yes that's exactly this. I've added a few lines on this in the readme because
it's not the first time people get trapped and we can't expect them to be
aware of it if it's not documented anywhere.

Thanks!
Willy


Reply via email to