Hello, On Saturday, November 23, 2013, Willy Tarreau wrote:
> Hello Kristoffer, > > On Fri, Nov 22, 2013 at 11:21:21AM +0100, Kristoffer Grönlund wrote: > > Hello, > > > > I have packaged haproxy 1.4.24 for openSUSE 13.1 [1], which uses systemd > > as the init system. At first I tried using a service script originally > > written for Fedora, but this script didn't handle configuration file > > reload in a good way. I then found the haproxy-systemd-wrapper > > committed upstream, which looked like a more viable approach. However, > > it didn't work for openSUSE mainly because SBINDIR didn't point to the > > correct directory. > > > > There was also an issue with the wrapper not cleaning up when killed by > > systemd, leaving zombie processes hanging. > > > > The attached patches should address both of these issues in a way that > > should work on any systemd-platform. I also added some logging to the > > systemd-wrapper so that it's easier to figure out what it does. > > > > The patched wrapper seems to work well for me, but any > > comments/suggestions are welcome. :) > > > > In case the patches get stripped, they are also available from my > > github account [2]. They are applied to a copy of 1.4.24 there, but > > should apply cleanly to the development tree. > > Great, thank you! I'll wait for Marc-Antoine to do a quick review since > he seems to be the only one here having had his fingers dirty with > systemd, then I have no problem merging them. > > Thanks! > Willy > > I don't have access to a computer to actually test those, but: - the first one looks nice, never felt really confident hard coding SBINDIR and the solution makes sense - nice catch for the second one, didn't think of the sigint when writing it, lgtm - third one is trivial enough not to harm anyone +1 for me Thanks! Marc-Antoine
