Hi Nenad, On Mon, Apr 14, 2014 at 12:39:23PM +0200, Nenad Merdanovic wrote: > I have attached another patch for review. I have removed some > ifdef/else/endif code and it looks to be more readable for me this way > (and in line how it was before this change). If you still prefer to have > an ifdef around the whole function body, let me know, I'll rewrite it.
At first glance it looks fine this way. > I was also not 100% sure about using GTUNE_USE flags, but seems like the > right way to do (as long as we don't see those flags as performance > tuning related only). Let me know if this is something you are willing > to merge and I'll write a proper commit message. You used it exactly the way it's supposed to be used, that's perfect. Unless someone else steps up with a comment, I agree with your patch. Please go forward by providing the commit message, I'll happily merge it. Thanks, Willy
