Re: [ANNOUNCE] haproxy-1.5-dev25

[Cyril Bonté]

Hi Baptiste,

Le 10/05/2014 23:20, Baptiste a écrit :
(...)
In my configuration, I have the following log-format directive:
log-format %ci:%cp\ [%t]\ %ft\ %b/%s\ %Tq/%Tw/%Tc/%Tr/%Tt\ %ST\ %B\
%CC\ %CS\ %tsc\ %ac/%fc/%bc/%sc/%rc\ %sq/%bq\ %hr\ %hs\
{%sslv,%sslc,%[ssl_fc_sni],%[ssl_fc_session_id]}\
"%[capture.req.method]\ %[capture.req.hdr(0)]%[capture.req.uri]\
%[capture.res.ver]"
The fetch ssl_fc_session_id just return weird characters in my log entries:
May 10 23:15:37 localhost haproxy[10282]: 88.160.139.122:51802
[10/May/2014:23:15:35.225] ft_www~ bk_wiki/centos5_www
1828/0/0/237/2065 200 5352 - - ---- 11/10/0/1/0 0/0
{wiki.bedis.eu|Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101
Firefox/|gzip, deflate}
{TLSv1,ECDHE-RSA-AES256-SHA,wiki.bedis.eu,0�#006sU#177.^��XP#005
"�V��CͶ�lgL�#004#026} "GET wiki.bedis.eu/index HTTP/1.1"


I used to have such type of string before:
{TLSv1.1,ECDHE-RSA-AES256-SHA,wiki.bedis.eu,E0CF269B6D688FA360C267FF021D7654601DD2D630944681A49EB42605FD49DB}

But I can't say when this change occured, because I don't update and
watch my log every day :)

Note: from the doc, I can read that ssl_fc_session_id is supposed to be binary.

I think the behaviour has changed since dev23. I've not tested to verify 
it but it may be related to the 2 commits :
http://haproxy.1wt.eu/git?p=haproxy.git;a=commit;h=e87cac16cc082fa43d5f65dd68e1244add7871c6
http://haproxy.1wt.eu/git?p=haproxy.git;a=commit;h=2f49d6d17be8825a2c64ed89434d85959b8000f8

Using %[ssl_fc_session_id,hex] should restore your behaviour.

--
Cyril Bonté