Hi Lukas,

On Fri, Jul 18, 2014 at 08:30:23PM +0200, Lukas Tribus wrote:
> FYI when compiling current haproxy-1.5 with openssl, compiler warns:
> 
> src/connection.c: In function ?make_proxy_line_v2?:
> src/connection.c:687:5: warning: passing argument 2 of 
> ?ssl_sock_get_remote_common_name? from incompatible pointer type [enabled by 
> default]
> include/proto/ssl_sock.h:55:5: note: expected ?struct chunk *? but argument 
> is of type ?struct chunk **?

Wow yes indeed that's a bug, it should have been "cn_trash" and not
"&cn_trash". Dave, you didn't test this with a valid client cert, did
you ? Otherwise I don't see how it could have worked, it might even
have crashed when dereferencing the corrupted data in cn_trash.

Thanks Lukas for spotting this, I've pushed the fix to both 1.5 and 1.6.

Cheers,
Willy


Reply via email to