Willy
Thanks, was in a hurry, every project is a little different in
process. Attached.
On Tue, Oct 7, 2014 at 7:44 AM, Willy Tarreau <w...@1wt.eu> wrote:
> On Tue, Oct 07, 2014 at 07:28:55AM -0500, Andrew Latham wrote:
>> Willy
>>
>> Diff attached. Happy to help if there are any issues.
>
> Andrew, if I asked for the format-patch output, it's because it
> provides your commit message, your authorship etc...
>
> You just have to do this :
>
> git format-patch -1 $COMMIT
>
> with the commit ID in $COMMIT, or simply "git format-patch -1" if
> the commit is the last one.
>
> Then it gives you a file named 0001-your-subject.patch that you
> can simply send and that I'll apply using "git am". It's also
> very convenient for reviewers since they can make comments inline
> about some specific parts of code.
>
> Also, keep in mind that having a patch ready for merging is the
> best way to ensure it will get quickly accepted. On the opposite,
> expecting any upstream maintainer to write the commit message
> themselves for something they did not write is the best way to
> ensure the patch will stay there forever.
>
> Last, please take a look at section 5 of the README ("how to
> contribute"), it explains how to write a relevant subject that I
> will not have to edit when merging it. That's equally a key to
> having your patches quickly merged.
>
> Do not hesitate to ask for any help, it's very important for me
> that contributors feel at ease with submitting changes. Don't be
> afraid of doing mistakes, we all do.
>
> Thanks,
> Willy
>
--
~ Andrew "lathama" Latham lath...@lathama.com http://lathama.net ~
From 927c07583d55c3033eb76cee54c8c246d51736e4 Mon Sep 17 00:00:00 2001
From: Andrew Latham <lath...@gmail.com>
Date: Tue, 7 Oct 2014 07:45:54 -0500
Subject: [PATCH] DOC: Address issue where documentation is excluded due to a
gitignore rule.
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index ec1545a..762f5ad 100644
--- a/.gitignore
+++ b/.gitignore
@@ -12,6 +12,7 @@ src/*.o
*.log*
*.trace*
haproxy-*
+!doc/haproxy-*.txt
!src/*.c
make-*
dlmalloc.c
--
2.1.1
