On Sun, Nov 01, 2015 at 09:20:53PM +0100, Jérôme Duval wrote: > Hello Willy, > > 2015-11-01 20:20 GMT+01:00 Willy Tarreau <[email protected]>: > > On Sun, Nov 01, 2015 at 01:18:00PM +0100, Jérôme Duval wrote: > >> * don't install the systemd-wrapper for all platforms, replace it with > >> $(EXTRA) like the "all" target already does. > > > > This case is not specific to your operating system, in fact only a > > minority of platforms need the systemd-wrapper. I personally build > > with "make ... EXTRA=" to avoid building it and installing it. I > > think we took the wrong approach by enabling it by default, since > > we're bothering all platforms. We should probably change this to > > have a "linux-systemd" target which enables it. > > > > If nobody objects, I'd rather do that so that you don't have to add > > a specific if/elif/endif just for this. What do you think ? > > EXTRA is already correctly set to haproxy-systemd-wrapper for > platforms which might care (linux26 and linux2628). Please note that > the systemd-wrapper isn't built by default, only installed by default, > which is the problem I met, and tried to fix in this patch (I could > have better worded my commit message). I hope it helps.
Ah OK indeed! Then that's fine. I'd prefer to split your patch in two because then it fixes a bug since the installation is forced on platforms which do not build it and will necessarily result in an error. And of course, I'm seeing that just a few minutes after I've tagged 1.5.15, as usual :-/ If you can split it, I'd appreciate it, otherwise I'll do it once I'm done with the 1.5.15 changelog and announce. Thanks! Willy
