On 02/11/2015 09:34 πμ, Baptiste wrote: > On Fri, Oct 30, 2015 at 3:22 PM, Pavlos Parissis > <[email protected]> wrote: >> Hi, >> >> Following resolver section passes configuration check >> resolvers mydns1 >> nameserver ns1 8.8.8.8:53 >> nameserver ns1 8.8.4.4:53 >> resolve_retries 3 >> timeout retry 1s >> hold valid 10s >> >> IMHO: allowing same ID for 2 different objects, which have stats attached to >> them, may not be the best approach here. Since, HAProxy doesn't allow more >> than one resolver sections with same name, I would say for consistency >> reasons should do the same for nameserver parameters within the same >> resolver section. >> >> If IDs for nameserver are different then you can fetch stats per nameserver: >> echo 'show stat resolvers mydns1 ns1'|socat /run/haproxy/admin1.sock stdio >> >> Cheers, >> Pavlos >> > > > Hi Pavlos, > > I agree with you. > If you think you can contribute this, feel free, otherwise, let me > know and I'll do it.
I can't code in C, sorry:-), but I can test your patch. > If we go into this direction, we also may add an 'id' keyword, to > force the nameserver uuid, like on the server line. > > We may backport only uuid in 1.6, since other changes may break > existing configuration. Only if the configuration has 2 nameservers with the same id, which isn't very likely as nobody wont configure HAProxy like this. I found it while I was adding support for nameservers in haproxyadmin lib and accidentally used the same id:-) > I'll discuss this point with Willy. > > Batpiste Thanks a lot, Pavlos
signature.asc
Description: OpenPGP digital signature
