Hi, there is a small bug in dumpstats.c, stats_dump_fields_csv(). One of the writes is to the global `trash` chunk, which happens to be the right one, but it should be to what gets passed in as argument (out).
Not even sure this was worth a patch, but it is attached if you like. Otherwise, feel free to just fix by hand :) Happy weekend, Conrad -- Conrad Hoffmann Traffic Engineer SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany Managing Director: Alexander Ljung | Incorporated in England & Wales with Company No. 6343600 | Local Branch Office | AG Charlottenburg | HRB 110657B
>From 5ec0353a7c06c51053995bba76e3fd0143e7a8d8 Mon Sep 17 00:00:00 2001 From: Conrad Hoffmann <con...@soundcloud.com> Date: Fri, 1 Apr 2016 20:40:58 +0200 Subject: [PATCH] BUG/MINOR: dumpstats: fix write to global chunk This just happens to work as it is the correct chunk, but should be whatever gets passed in as argument. Signed-off-by: Conrad Hoffmann <con...@soundcloud.com> --- src/dumpstats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dumpstats.c b/src/dumpstats.c index 341fd56..3299f1b 100644 --- a/src/dumpstats.c +++ b/src/dumpstats.c @@ -3211,7 +3211,7 @@ static int stats_dump_fields_csv(struct chunk *out, const struct field *stats) if (!chunk_strcat(out, ",")) return 0; } - chunk_strcat(&trash, "\n"); + chunk_strcat(out, "\n"); return 1; } -- 2.7.4
