Hi all, Here an harmless little cleanup patch.
Hope it finds its way. Regards.
From 50f7117a14780b491c33a12fc631e5e75e8c185e Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Mon, 27 Jun 2016 14:12:59 +0100 Subject: [PATCH] CLEANUP: dumpstats: u64 field is an unsigned type. The check will always be true, thus unnecessary. --- src/dumpstats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dumpstats.c b/src/dumpstats.c index 1e823d0..c88d0ac 100644 --- a/src/dumpstats.c +++ b/src/dumpstats.c @@ -3702,7 +3702,7 @@ static int stats_dump_fields_html(struct chunk *out, const struct field *stats, if (stats[ST_F_AGENT_CODE].type) chunk_appendf(out, "/%d", stats[ST_F_AGENT_CODE].u.u32); - if (stats[ST_F_AGENT_DURATION].type && stats[ST_F_AGENT_DURATION].u.u64 >= 0) + if (stats[ST_F_AGENT_DURATION].type) chunk_appendf(out, " in %lums", (long)stats[ST_F_AGENT_DURATION].u.u64); chunk_appendf(out, "<div class=tips>%s", field_str(stats, ST_F_AGENT_DESC)); @@ -3722,7 +3722,7 @@ static int stats_dump_fields_html(struct chunk *out, const struct field *stats, if (stats[ST_F_CHECK_CODE].type) chunk_appendf(out, "/%d", stats[ST_F_CHECK_CODE].u.u32); - if (stats[ST_F_CHECK_DURATION].type && stats[ST_F_CHECK_DURATION].u.u64 >= 0) + if (stats[ST_F_CHECK_DURATION].type) chunk_appendf(out, " in %lums", (long)stats[ST_F_CHECK_DURATION].u.u64); chunk_appendf(out, "<div class=tips>%s", field_str(stats, ST_F_CHECK_DESC)); -- 2.7.4
