On 17/03/2017 05:57 μμ, Aleksandar Lazic wrote: > Willy. > > Am 14-03-2017 22:17, schrieb Willy Tarreau: >> Matthias, >> >> I could finally track the problem down to a 5-year old bug in the >> connection handler. It already used to affect Unix sockets but it >> requires so rare a set of options and even then its occurrence rate >> is so low that probably nobody noticed it yet. >> >> I'm attaching the patch to be applied on top of 1.7.3 which fixes it, >> it will be merged into next version. >> >> Dmitry, you may prefer to take this one than to revert the previous >> one from your ports, especially considering that a few connect() >> immediately succeed over the loopback on FreeBSD and that it was >> absolutely needed to trigger the bug (as well as the previously fixed >> one, which had less impact). >> >> Or you may prefer to wait for 1.7.4. It's not planned yet given that >> there are other fixes in the wild waiting for some feedback though. >> >> Thanks guys for the detailed feedback, it's now time to turn the page >> and switch to less difficult ones! > > I love your commit massages ;-). >
+1 > They are very detailed and sometimes bigger the the code change. > Indeed. All commits, in any project, should be like this. I personally follow the following rules: 1. short commit should be written, so that can be placed in the following sentence: If you apply this commit it will <short commit message> 2. Long commit message should clearly describe the problem, why it is a problem and how the commit fixes the problem. Having said, I have colleagues that not only follow the above rules but complain to me about my very lengthy commit messages. I usually ignore them and redirect their *rant* to /dev/null. Cheers, Pavlos
signature.asc
Description: OpenPGP digital signature
