On 05/12/2017 09:37 AM, Willy Tarreau wrote:
On Fri, May 12, 2017 at 08:58:56AM +0200, Lukas Tribus wrote:
Hi,


Am 11.05.2017 um 21:13 schrieb Jim Pingle:
On 05/11/2017 01:58 PM, Frederic Lecaille wrote:
I have reproduced (at home) the stats socket issue within a FreeBSD 9.3 VM.

Replacing your call to close() by fd_delete() which removes the fd from
the fd set used by kevent *and close it* seems to fix at least the stats
socket issue. I do not know if there are remaining ones.

I did not reproduced the kevent issue revealed by Lukas traces. But I
had other ones : ERR#57 'Socket is not connected' during sendto().

I attached a temporary patch to be validated and to let you perhaps
provide a better one as I have not double check everything.
Fred,

That seems to have fixed the problem for me. With that patch applied,
web traffic passes and the UNIX socket responds.

Confirmed, works for me too. Baptiste? Willy? Is this an acceptable fix?

Yes definitely, not only an acceptable one, but the right fix. I understand
why it happens to work on linux, by default close() unregisters FDs from
epoll so it passed below the radar.

Ok so Willy I will send a well-formed patch asap.



Reply via email to