On Tue, May 30, 2017 at 12:39:32PM +0200, Willy Tarreau wrote: > [...] > > The master, not intercepting this signal, would die, closing the pipe. > The worker would be woken up on the detection of this closure, and while > trying to perform the read() would get the signal in turn, causing the > read() to return EINTR and to stop polling on this fd instead of exiting. >
You are absolutely right, I'll fix that. > > Regarding the environment variable names, it's preferable to prepend > "HAPROXY" in front of them as we've been doing for all other ones to > avoid namespace conflicts with anything used in other environments (I've > ween places where you had to run "env|grep" to find your variable). I've > seen another one called "WAIT_ONLY" in one of the first patches and > which should equally be renamed. > Will do. > Otherwise the series looks quite good, it would be nice to get some > feedback especially from systemd hostages^Wusers (my comments above > will not affect their experience unless they're really unlucky). > > Thanks! > Willy > I'll send you another batch with the fixes, and maybe some cleanup. In the meanwhile people can still try them. -- William Lallemand
