Hi Willy, I have pulled the latest master, but I only see two commits from today. I assume I'm in the right place " http://git.haproxy.org/git/haproxy";?
Using 3.2.10 in 1.7 is fine for Pattern, my only concern is that the old Trie source is not available to for users to compile in 3.2.10. All method signatures in 3.2.12 are unchanged from 3.2.10, so using that in 1.7 will not be a problem. If you are more comfortable keeping that locked to the fixed 3.2.10, then that is fine, but the line of Dragan's statement should then read something like "either use the proven stable but frozen 3.2.10 version which supports the Pattern algorithm". Or, if it makes things easier for you, I can backport the trie/51Degrees.c/h files to 3.2.10, meaning Trie can be used in that version (the Hash Trie files we now distribute will be needed instead of the deprecated Trie). Thanks, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -----Original Message----- From: Willy TARREAU [mailto:wtarr...@haproxy.com] Sent: 05 October 2017 16:40 To: Ben Shillito <b...@51degrees.com> Cc: Dragan Dosen <ddo...@haproxy.com>; haproxy@formilux.org Subject: Re: [PATCHES] 51d: fix warning when building with 51Degrees release version 3.2.12.12 On Thu, Oct 05, 2017 at 03:15:20PM +0000, Ben Shillito wrote: > Yes of course. I have attached a patch which has the correct branch and > updated instructions about where to get the free Hash Trie file now that it > is no longer part of the git repository. But this one is for the doc before Dragan's patch, please pull the master. By the way this makes me realize that we'll probably need to have a different doc for 1.7 and 1.8. I agree with you that 1.8 should only reference the up to date version. Build instructions for 3.2.10 should only appear in 1.7 and older for people who rely on an old signature, but there the download URL and instructions for 3.2.12 should be correct as well. So feel free to update your patch on top of the current master, removing references to 3.2.10 and Trie, and I'll take Dragan's patch + the part relevant to 3.2.12 for 1.7 to encourage users to upgrade without forcing them. Thanks! Willy This email and any attachments are confidential and may also be privileged. If you are not the named recipient, please notify the sender immediately and do not disclose, use, store or copy the information contained herein. This is an email from 51Degrees.mobi Limited, 5 Charlotte Close, Reading. RG47BY. T: +44 118 328 7152; E: i...@51degrees.com; 51Degrees.mobi Limited t/as 51Degrees.
