Hi here a tiny fix proposal for the previous commit. Hope it is good.
Kind regards.
From c1f299b45e56c77fc51b2e773272195ddaee46a7 Mon Sep 17 00:00:00 2001 From: David Carlier <devne...@gmail.com> Date: Thu, 11 Jan 2018 14:20:43 +0000 Subject: [PATCH] BUILD/MINOR: ancient gcc versions atomic fix Commit 1a69af6d3892fe1946bb8babb3044d2d26afd46e introduced code for atomic prior to 4.7. Unfortunately clang uses as well those constants which is misleading. --- include/common/hathreads.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/common/hathreads.h b/include/common/hathreads.h index 503abbec..5f0b9695 100644 --- a/include/common/hathreads.h +++ b/include/common/hathreads.h @@ -100,7 +100,7 @@ extern THREAD_LOCAL unsigned long tid_bit; /* The bit corresponding to the threa /* TODO: thread: For now, we rely on GCC builtins but it could be a good idea to * have a header file regrouping all functions dealing with threads. */ -#if defined(__GNUC__) && (__GNUC__ < 4 || __GNUC__ == 4 && __GNUC_MINOR__ < 7) +#if defined(__GNUC__) && (__GNUC__ < 4 || __GNUC__ == 4 && __GNUC_MINOR__ < 7) && !defined(__clang__) /* gcc < 4.7 */ #define HA_ATOMIC_ADD(val, i) __sync_add_and_fetch(val, i) -- 2.15.1
