Hi Thierry, On Tue, Jun 26, 2018 at 10:20:38AM +0200, [email protected] wrote: > BR,Hi, > > I found the bug. The segfault is unavoidable, because is trigged if an > entry doesn't exists in the stick-tables. At the start, the stick table > is empty. > > It is a regression introduced in 1.8.10 by this patch: > > BUG/MEDIUM: stick-tables: Decrement ref_cnt in table_* converters > commit d7bd88009d88dd413e01bc0baa90d6662a3d7718 > Author: Daniel Corbett <[email protected]> > Date: Sun May 27 09:47:12 2018 -0400
Oh crap :-( I noticed the memory leaks in the first version but I did not notice this one, which is pretty visible nonetheless given the test on !!ts 2 lines above :-( > I join a patch. > > Daniel, could you check the compliance with your original patch ? Your patch is obviously good, I've just merged it. > William, The backport in 1.8 stable is trivial. William / Christopher, given that 1.8.10 is very recent and few people had the time to upgrade, I think it would make sense to issue 1.8.11 to limit the risks. I don't like such bugs which crash at runtime while you're drinking coffee after the upgrade. Thanks Thierry! Willy
