Willy, Am 26.06.2018 um 16:17 schrieb Willy Tarreau: > On Tue, Jun 26, 2018 at 03:57:29PM +0200, Tim Duesterhus wrote: >> diff --git a/src/stick_table.c b/src/stick_table.c >> index 42946545..8e16830d 100644 >> --- a/src/stick_table.c >> +++ b/src/stick_table.c >> @@ -1596,8 +1596,10 @@ static int sample_conv_table_trackers(const struct >> arg *arg_p, struct sample *sm >> smp->data.type = SMP_T_SINT; >> smp->data.u.sint = 0; >> >> - if (ts) >> - smp->data.u.sint = ts->ref_cnt; >> + if (!ts) >> + return 1; >> + >> + smp->data.u.sint = ts->ref_cnt; >> >> stktable_release(t, ts); >> return 1; > > Well, I don't understand, this does exactly the same as the current patch > (except that your version is not thread safe), given that right now it > does this : >
Note that I edited a different function: - Tim : sample_conv_table_trackers vs - Thierry: sample_conv_in_table In sample_conv_table_trackers I explicitely added the return to make the function body look like 'sample_conv_table_conn_cur' (though I forgot to add the `/* key not present */` comment, can you do so when applying?). I believe that you missed the fact that I edited a different function and thus I believe that your remaining points do not apply? Best regards Tim Düsterhus
