On Thu, Dec 13, 2018 at 8:41 PM Willy Tarreau <w...@1wt.eu> wrote:
>
> Hello,
>
> On Thu, Dec 13, 2018 at 02:20:06PM -0800, Rosen Penev wrote:
> > Signed-off-by: Rosen Penev <ros...@gmail.com>
>
> Could you please provide a real commit message explaining what is the
> problem you're trying to solve, how it manifests itself, and in what
> condition it was tested as appropriate ?
Will do so.
>
> In addition, do you know if it still works with libressl/boringssl ?
This will break LibreSSL as they broke OPENSSL_VERSION_NUMBER.
BoringSSL should be fine.
> Some users rely on these forks and I know that we very easily break
> them once in a while when touching the API. I'm fine if you don't
> know since these forks are not our primary target, but it's good to
> know upfront what to expect (especially for those who might have to
> get back to this patch if some breakage is detected).
>
> Thanks,
> Willy
