Hi Lukas, On Thu, Apr 18, 2019 at 08:45:18PM +0200, Lukas Tribus wrote: > Hi Willy, > > > On Fri, 8 Mar 2019 at 14:23, PR Bot <haproxy-pr-bot-no-re...@ltri.eu> wrote: > > > > Dear list! > > > > Author: Radek Zajic <radek.za...@showmax.com> > > Number of patches: 1 > > > > This is an automated relay of the Github pull request: > > IPv6: properly format an address coming from IPv6 socket as hex in > > lf_ip > > > > Patch title(s): > > IPv6: properly format an address coming from IPv6 socket as hex string > > in lf_ip > > > > Link: > > https://github.com/haproxy/haproxy/pull/59 > > > > Edit locally: > > wget https://github.com/haproxy/haproxy/pull/59.patch && vi 59.patch > > > > Apply locally: > > curl https://github.com/haproxy/haproxy/pull/59.patch | git am - > > > > Description: > > Dear `haproxy` maintainers, > > > > we've recently discovered an > > issue with formatting IPv6 addresses as hex strings (in e.g. > > `%{+X}ci`). This issue occurs e.g. when formatting `unique-id-format` > > as recommended in the docs: `%{+X}o\ %ci:%cp_%fi:%fp_%Ts_%rt:%pid`. > > This pull request proposes a change that properly formats addresses > > from IPv4 sockets as 8-char hex-string and addresses from IPv6 sockets > > as 32-char hex-string. > > [...] > > > For housekeeping purposes: I believe this patch fall through the > cracks (I did not look at it though).
You're right. I thought I took it already but very likely I was too busy to spend time figuring what the original issue was and redoing it with a proper commit message :-/ Radek, please have a look at CONTRIBUTING and make sure that your commit message explains what the problem was, what solution you decided on and why it's supposedly the best. Also any hint about the suitability for backporting to stable branches would be welcome. Thanks, Willy
