Hi Willy, Great, thanks for those changes, and good spot.
I agree that this is a significant step forward, and having the entire codebase testable in CI will certainly make everything that bit smoother. Thanks, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -----Original Message----- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 12 June 2019 17:07 To: Ben Shillito <b...@51degrees.com> Cc: Christopher Faulet <cfau...@haproxy.com>; HAProxy <haproxy@formilux.org> Subject: Re: [PATCH] wurfl device detection build fixes and dummy library On Wed, Jun 12, 2019 at 02:49:37PM +0000, Ben Shillito wrote: > While I was working on the HTX changes, I thought it was probably a > good time to also implement the dummy library as I had my brain in 'HAProxy > mode'. Ah, excellent, thank you : $./haproxy -vv|grep -i 51d Feature list : +EPOLL -KQUEUE -MY_EPOLL -MY_SPLICE +NETFILTER +PCRE -PCRE_JIT -PCRE2 -PCRE2_JIT +POLL -PRIVATE_CACHE +THREAD -PTHREAD_PSHARED -REGPARM -STATIC_PCRE -STATIC_PCRE2 +TPROXY +LINUX_TPROXY +LINUX_SPLICE +LIBCRYPT +CRYPT_H -VSYSCALL -GETADDRINFO +OPENSSL +LUA +FUTEX +ACCEPT4 -MY_ACCEPT4 -ZLIB +SLZ +CPU_AFFINITY -TFO +NS +DL +RT -DEVICEATLAS -51DEGREES -WURFL -SYSTEMD -OBSOLETE_LINKER +PRCTL +THREAD_DUMP -EVPORTS Built with 51Degrees support. :-) Ilya will likely be happy to see that we can now build 100% of our codebase in the CI, this is a significant step forward! I performed very minor changes to your patches, for the first one I marked it "BUG/MINOR" so that we backport it to 1.9 (since it's still broken there) and for the second I fixed the doc where you accidently dropped "51d" after "contrib/" in the build command :-) Thanks a lot for your responsiveness, Willy This email and any attachments are confidential and may also be privileged. If you are not the named recipient, please notify the sender immediately and do not disclose, use, store or copy the information contained herein. This is an email from 51Degrees.mobi Limited, 5 Charlotte Close, Reading. RG47BY. T: +44 118 328 7152; E: i...@51degrees.com; 51Degrees.mobi Limited t/as 51Degrees.