Hi Luke, I remember I first did that intentionally to avoid values below 255 being "rounded" to 0... And I assumed people would remove servers from their DNS if they want a weight to 0.
Now, with some feedback, I can see I was wrong. Next time, don't hesitate to ask the question on the ML, or on github or to my mail directly. Baptiste On Mon, Oct 21, 2019 at 8:51 PM Luke Seelenbinder < luke.seelenbin...@stadiamaps.com> wrote: > Thank you for this bug fix…we're more than a little excited! > > When I initially found it, I was under the assumption it was on purpose. > :-) > > Best, > Luke > > — > Luke Seelenbinder > Stadia Maps | Founder > stadiamaps.com > > On 21 Oct 2019, at 16:35, Christopher Faulet <cfau...@haproxy.com> wrote: > > Le 21/10/2019 à 16:20, Baptiste a écrit : > > Thx to 2 people who spotted a bug in my patch, (missing parenthesis). > here is the updated version. > On Mon, Oct 21, 2019 at 3:59 PM Baptiste <bed...@gmail.com < > mailto:bed...@gmail.com <bed...@gmail.com>>> wrote: > hi there, > Following up some recent discussion about SRV record's weight and server > weight in HAProxy, we spotted a bug in the current code: when weight in > SRV > record is set to 0, then server weight in HAProxy was 1... > Thanks to Willy for proposing the solution applied into that patch. > Baptiste > > > Baptiste, > > I don't know if the comment is wrong or not. But with your patch, the > weight is now between 0 and 256. The function > server_parse_weight_change_request() is ok with that. So I can amend your > comment if you want. I just want to have a confirmation. > > -- > Christopher Faulet > > >
