Hi William, On Tue, May 05, 2020 at 11:57:47PM +0200, William Dauchy wrote: > > Christopher Faulet (136): > > MAJOR: checks: Implement HTTP check using tcp-check rules > > What is funny after this commit is that we wrongly relied on a config > which was written that way: > http-check expect status 200 string passing > instead of: > http-check expect status 200 > http-check expect string passing > > I first thought about a bad regression even though the documentation > does not allow it, but `string passing` was never evaluated, and so > silently ignored; now things are enforced which is better for us to > see those long standing mistakes ;)
Ah interesting. We have many checks for unused extraneous parameters, but it's possible that a few still managed to pass through. It might be good if we can adjust this one to at least emit a warning in older branches. Thanks for the feedback! Willy
