On Wed, May 13, 2020 at 04:01:02PM +0200, William Dauchy wrote:
> On Wed, May 13, 2020 at 03:52:54PM +0200, Willy Tarreau wrote:
> > > This one breaks clang builds because it removes the fail_revt label but 
> > > it is
> > > still declared as a local label, and clang errors on it.
> > 
> > Ah crap! I didn't notice this part which didn't appear in the context
> > of the patch. I didn't notice we still had a few such labels in very
> > old files. Do you mind if instead I edit your patch to completely remove
> > the line ?
> 
> ah sorry for that!

No problem. These shouldn't have existed in the first place. They
stemmed from a very old habit I grew 25 years ago with macros declaring
labels that would conflict with the call place's, and I finally ended up
putting __label__ everywhere I would need one.

Now applied, thanks Jérôme.

Willy

Reply via email to