Hi Christopher,

Thanks for the review.

On Mon, Jan 25, 2021 at 4:26 PM Christopher Faulet <cfau...@haproxy.com> wrote:
> Here, you must take care to increment "*nbup" and "*nbsrv" in the for loop. 
> But
> changing it this way gcc then complains these variables are now unused. Thus 
> to
> make it happy, I must use local variables.

ah yes, I forgot the * indeed.
I did modify the code to use local variables but it somehow looks
uglier than before.
see in v2.

> Take a look at the commit 8596bfbaf ("BUG/MINOR: stats: Init the metric 
> variable
> when frontend stats are filled"). The metric variable must be initialized.

fixed in v2


--
William

Reply via email to