Hi Jarno,
On Tue, Apr 13, 2021 at 06:19:47AM +0000, Jarno Huuskonen wrote:
> Hello,
>
> On Tue, 2021-04-06 at 01:58 +0200, Moemen MHEDHBI wrote:
> > Thanks Willy and Tim for your feedback.
> >
> > You can find attached the updated patches with fixed coding style (now
> > set correctly in my editor), updated commit message, entry doc in sorted
> > order, size_t instead of int in both enc/dec and corresponding reg-test.
>
> Could you add a cross reference from b64dec/base64 to ub64dec/ub64enc in
> configuration.txt. Something like:
> --- a/doc/configuration.txt
> +++ b/doc/configuration.txt
> @@ -15020,11 +15020,14 @@ and(<value>)
> b64dec
> Converts (decodes) a base64 encoded input string to its binary
> representation. It performs the inverse operation of base64().
> + For base64url("URL and Filename Safe Alphabet" (RFC 4648)) variant
> + see "ub64dec".
>
> base64
> Converts a binary input sample to a base64 string. It is used to log or
> transfer binary content in a way that can be reliably transferred (e.g.
> - an SSL ID can be copied in a header).
> + an SSL ID can be copied in a header). For base64url("URL and Filename
> Safe
> + Alphabet" (RFC 4648)) variant see "ub64enc".
>
> bool
> Returns a boolean TRUE if the input value of type signed integer is
Yes very good point indeed, and similarly the ub64 ones should refer to
these ones.
Willy
