Tim, Ilya,

while testing Miroslav's fix, I found the opentracing build to be quite
slow and figured it doesn't use parallel builds. Do you have any objection
against patching the script like this ?

diff --git a/scripts/build-ot.sh b/scripts/build-ot.sh
index 59d6af587..1c296b64b 100755
--- a/scripts/build-ot.sh
+++ b/scripts/build-ot.sh
@@ -19,7 +19,7 @@ if [ "$(cat ${HOME}/opt/.ot-cpp-version)" != 
"${OT_CPP_VERSION}" ]; then
     mkdir build
     cd build
     cmake -DCMAKE_INSTALL_PREFIX=${HOME}/opt -DBUILD_STATIC_LIBS=OFF 
-DBUILD_MOCKTRACER=OFF -DBUILD_TESTING=OFF >
-    make
+    make -j$(nproc)
     make install
     echo "${OT_CPP_VERSION}" > "${HOME}/opt/.ot-cpp-version"
 fi
@@ -28,7 +28,7 @@ git clone 
https://github.com/haproxytech/opentracing-c-wrapper.git
 cd opentracing-c-wrapper
  ./scripts/bootstrap
  ./configure --prefix=${HOME}/opt --with-opentracing=${HOME}/opt
- make
+ make -j$(nproc)
  make install

I'm assuming it's already made to build only in environments we support
so we shouldn't care about the presence of the nproc utility there.

Thanks,
Willy

Reply via email to