On Thu, Jun 17, 2021 at 05:03:23PM +0200, Tim Düsterhus wrote: > On 6/17/21 3:27 PM, Willy Tarreau wrote: > > Whole series merged, thanks Tim. I feel like the selection is slightly > > faster than before, but that might just be a placebo effect. > > > > I would assume that it's slightly slower, because we need to launch more > executables compared to before. 'haproxy -cc' is executed once for each > test, instead of 'haproxy -vv' being run once and the results stored in > variables.
So I've measured before and after your patch and the total time dropped from 9.2 to 8.7, so we're definitely saving half a second there, which is not bad at all! > Even if it's slower I think it's definitely worth for the improved > flexibility. Definitely! > I'll also try to look into replacing the 'EXCLUDE_TARGETS' check with calls > to 'uname'. Maybe wait a bit for expression to be supported in predicates, then we might be able to build some convenient ones which validate everything at once and we'll then get the full flexibility in a single test. Just my two cents, Willy
