Willy,
On 11/8/21 11:43 AM, Willy Tarreau wrote:
You're totally right. Not only it is redundant, but it is wrong (which
is why it is redundant). By being called strncat() one would hope that
it never copies more than the source, but here it ignores the source's
size and always takes the len argument. I suggest that we replace it
with chunk_memcat() everywhere and remove it to avoid any issue. At
first glance for now this is harmless, fortunately, but for how long?
I'm going to do it, and have already applied your 6 first patches here.
Thanks for handling this.
Can you please revert b9656e48377a9e5359494bce6a413a9915c8f74b then?
This Coccinelle patch is no longer needed / correct now that the
function is gone.
Best regards
Tim Düsterhus
