Willy,

On 8/29/22 09:23, PR Bot wrote:
Author: cui fliter <[email protected]>
Number of patches: 1

This is an automated relay of the Github pull request:
    fix some typos

Patch title(s):
    fix some typos

Link:
    https://github.com/haproxy/haproxy/pull/1843

Edit locally:
    wget https://github.com/haproxy/haproxy/pull/1843.patch && vi 1843.patch

Apply locally:
    curl https://github.com/haproxy/haproxy/pull/1843.patch | git am -


The fixes look correct to me, but the commit message is horrible. I've attached the patch with a proper commit message (dropping the Signed-off-by and adding a Co-authored-by).

Best regards
Tim Düsterhus
From e2fa51bc9f7e7d7d451df2ad9cd72071211faf6a Mon Sep 17 00:00:00 2001
From: cui fliter <[email protected]>
Date: Mon, 29 Aug 2022 14:42:57 +0800
Subject: [PATCH] CLEANUP: Fix typos in C comments

see GitHub PR #1843

[Tim: Rephrased the commit message]

Co-authored-by: Tim Duesterhus <[email protected]>
---
 src/mux_quic.c | 2 +-
 src/quic_tls.c | 4 ++--
 src/ssl_sock.c | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mux_quic.c b/src/mux_quic.c
index bf91750c5e..937a8cb146 100644
--- a/src/mux_quic.c
+++ b/src/mux_quic.c
@@ -2296,7 +2296,7 @@ static int qc_wake(struct connection *conn)
 
 	/* Check if a soft-stop is in progress.
 	 *
-	 * TODO this is revelant for frontend connections only.
+	 * TODO this is relevant for frontend connections only.
 	 *
 	 * TODO Client should be notified with a H3 GOAWAY and then a
 	 * CONNECTION_CLOSE. However, quic-conn uses the listener socket for
diff --git a/src/quic_tls.c b/src/quic_tls.c
index 3114aa623c..a216f8678e 100644
--- a/src/quic_tls.c
+++ b/src/quic_tls.c
@@ -363,7 +363,7 @@ int quic_tls_enc_aes_ctx_init(EVP_CIPHER_CTX **aes_ctx,
 }
 
 /* Encrypt <inlen> bytes from <in> buffer into <out> with <ctx> as AES
- * cipher context. This is the responsability of the caller to check there
+ * cipher context. This is the responsibility of the caller to check there
  * is at least <inlen> bytes of available space in <out> buffer.
  * Return 1 if succeeded, 0 if not.
  */
@@ -403,7 +403,7 @@ int quic_tls_dec_aes_ctx_init(EVP_CIPHER_CTX **aes_ctx,
 }
 
 /* Decrypt <in> data into <out> with <ctx> as AES cipher context.
- * This is the responsability of the caller to check there is at least
+ * This is the responsibility of the caller to check there is at least
  * <outlen> bytes into <in> buffer.
  * Return 1 if succeeded, 0 if not.
  */
diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index 84e03d33b1..cf9c57634d 100644
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -2177,7 +2177,7 @@ static int ssl_sock_advertise_alpn_protos(SSL *s, const unsigned char **out,
 #ifdef SSL_CTRL_SET_TLSEXT_HOSTNAME
 #ifndef SSL_NO_GENERATE_CERTIFICATES
 
-/* Configure a DNS SAN extenion on a certificate. */
+/* Configure a DNS SAN extension on a certificate. */
 int ssl_sock_add_san_ext(X509V3_CTX* ctx, X509* cert, const char *servername) {
 	int failure = 0;
 	X509_EXTENSION *san_ext = NULL;
-- 
2.37.3

Reply via email to