Classification: UK OFFICIAL
Hi Christopher, Many thanks - good point regarding EHLO reply and yes, if you could add the backports / reg-tests parts as well that would be brilliant. This is my first ever patch submission so am keen to learn all the necessary parts for next time! Lawrence -----Original Message----- Sent: 21 September 2022 15:01 Subject: Re: [UK OFFICIAL] [PATCH] Issue 1812 - smtpchk option does not send a QUIT Le 9/21/22 à 11:42, Wright Loz a écrit : > Classification: UK OFFICIAL > > > Hi, > > Reference Github issue 1812 ( > https://scanmail.trustwave.com/?c=7369&d=o5ur46z2NyramAKsneIZdtswOxMGW > PTlZ6o4ClJe-Q&u=https%3a%2f%2fgithub%2ecom%2fhaproxy%2fhaproxy%2fissue > s%2f1812 > <https://scanmail.trustwave.com/?c=7369&d=o5ur46z2NyramAKsneIZdtswOxMG > WPTlZ6o4ClJe-Q&u=https%3a%2f%2fgithub%2ecom%2fhaproxy%2fhaproxy%2fissu > es%2f1812> ) relating to unclean shutdown of “smtpchk” health > checking, I attach a patch which implements an SMTP QUIT (and then a wait for > successful confirmation) prior to closing the TCP connection on each SMTP > service check. > > Hopefully relatively straightforward and obviously happy to discuss! > It seems to be ok at first glance. However, I must fix the regex to properly match the EHLO reply first. It is a multi-line reply and, for now, the regex is only matching on the first line. I will fix it before merging your patch. In addition and if it is ok for you, I will amend you patch to add information about backports and to update reg-tests accordingly (reg-tests/checks/4be_1srv_smtpchk_httpchk_layer47errors.vtc and reg-tests/checks/smtp-check.vtc) Thanks ! -- Christopher Faulet "This e-mail and any attachment(s) is intended for the recipient only. Its unauthorised use, disclosure, storage or copying is not permitted. Communications with Dstl are monitored and/or recorded for system efficiency and other lawful purposes, including business intelligence, business metrics and training. Any views or opinions expressed in this e-mail do not necessarily reflect Dstl policy." "If you are not the intended recipient, please remove it from your system and notify the author of the email and central...@dstl.gov.uk"
