Hi Tim,

On Mon, Mar 27, 2023 at 03:26:51PM +0200, Tim Düsterhus, WoltLab GmbH wrote:
> From d1c3bd09b95e6f68d8dc849b0637088b79856fbc Mon Sep 17 00:00:00 2001
> From: Tim Duesterhus <duester...@woltlab.com>
> Date: Mon, 27 Mar 2023 15:23:44 +0200
> Subject: [PATCH] BUG/MINOR: Fix typo in `TotalSplicedBytesOut` field name
> To: haproxy@formilux.org
> Cc: w...@1wt.eu
> 
> An additiona `d` slipped in there.
> 
> This likely should not be backported, because scripts might rely on the
> typoed name.

Hmmm that's embarrassing indeed. On the one hand we should consider
that it's part of the visible API and should stay like this eternally
(like "Referer" in HTTP). On the other hand, it was introduced only in
2.3, splicing is not the most commonly used feature (to say the least),
and the likelihood that it had ever been used is extremely faint, so it
is tempting to fix it before its use is widespread. This is also supported
by search engines not reporting any occurrence of it aside a few rare
dumps.

However we are normally extremely careful about guaranteeing that a
stable user can upgrade to the next LTS version. And here this would
not be the case. So if we merge it into 2.8 I'd rather also backport
it to 2.7 so that we know that all 2.7 users can safely upgrade to 2.8
(and if it causes any trouble then we know we'll just have to revert
it from both places).

What do you think ?

Thanks,
Willy

Reply via email to