Hi Artur,

On 6/6/23 14:42, Artur wrote:
DOC: quic: fix misspelled tune.quic.socket-owner

Commit 511ddd5 introduced tune.quic.socket-owner parameter
related to QUIC socket behaviour.
However it was misspelled in configuration.txt in 'bind' section as
tune.quic.conn-owner.


I'm not a committer, but a regular contributor. I had a look: The patch looks pretty good, but the commit message is lacking a body, which is required as per:

https://github.com/haproxy/haproxy/blob/a475448161b406b0b81f5b551336417b05426492/CONTRIBUTING#L562-L567

As you already found the commit that introduced the issue, it would be a good opportunity to add a reference to the message body, something like:

The typo was introduced in commit 511ddd5785266c149dfa593582512239480e1688 ("MINOR: quic: define config option for socket per conn") and needs to be backported together with that commit (2.8 and possible 2.7).

Best regards
Tim Düsterhus

Reply via email to