Dear list, This PR request was not meant to be sent to the upstream repository. Furthermore, this is not ready to receive any maintainer feedback yet.
I accidentally selected the wrong base repository when I was about to create a draft PR to show my code to some colleagues. Unfortunately, I did not spot my mistake before the bot became active. Of course, I am aware that this does not meet the requirements for a contribution and it also was not meant to be. I am really sorry for creating spam here. I will send a new, fully compliant patch in the next weeks. I would highly appreciate, if you then could take a look at my changes. Best Regards, Alexander Stephan -----Original Message----- From: PR Bot <haproxy-pr-bot-no-re...@ltri.eu> Sent: Friday, June 30, 2023 1:23 PM To: haproxy@formilux.org Cc: Stephan, Alexander <alexander.step...@sap.com> Subject: [PR] Implement fetch for arbitrary TLV payloads [You don't often get email from haproxy-pr-bot-no-re...@ltri.eu. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Dear list! Author: Alexander Stephan <alexander.step...@sap.com> Number of patches: 1 This is an automated relay of the Github pull request: Implement fetch for arbitrary TLV payloads Patch title(s): Fully working version with debug statements and missing test Link: https://github.com/haproxy/haproxy/pull/2199 Edit locally: wget https://github.com/haproxy/haproxy/pull/2199.patch && vi 2199.patch Apply locally: curl https://github.com/haproxy/haproxy/pull/2199.patch | git am - Description: TODO: - [ ] Add / adjust test - [ ] Remove debug logs - [ ] Always append to the list and return the first hit or traverse the list and overwrite. This is relevant for duplicate TLV which are technically possible, although unusual. - [ ] Make CRC32 and NETNS fetchable for consistency - [ ] Formatting to meet HAProxy contribution guidelines Instructions: This github pull request will be closed automatically; patch should be reviewed on the haproxy mailing list (haproxy@formilux.org). Everyone is invited to comment, even the patch's author. Please keep the author and list CCed in replies. Please note that in absence of any response this pull request will be lost.
