Hi Brooks, On Fri, Mar 08, 2024 at 09:47:39PM +0000, Brooks Davis wrote: > On Fri, Mar 08, 2024 at 06:19:42PM +0100, Willy Tarreau wrote: > > Hi Dmitry, > > > > first, sorry for the long delay but these days I've been drained in a > > bunch of meetings and reviews that took more time than I expected! > > > > On Wed, Feb 28, 2024 at 11:06:00PM +0300, Dmitry Sivachenko wrote: > > > Hello! > > > > > > Recently FreeBSD has moved some things out from libc to libsys (see e.g > > > https://www.mail-archive.com/dev-commits-src-all@freebsd.org/msg50353.html) > > > So haproxy stopped compiling with "ld: error: undefined symbol: > > > __elf_aux_vector" error. > > > > > > Brooks Davis suggested the attached patch to fix that. > > > > > > Please consider including it into the tree. > > > > What's the oldest FreeBSD version that will build with this ? Shouldn't > > we just guard it by version ? This patch is pretty well isolated and in > > a place already full of ifdefs, so it would cost basically nothing to > > add a test for the FreeBSD version in addition to defined(): > > It looks like __elf_aux_vector is available since FreeBSD 9, > elf_aux_info since 12, and AT_EXECPATH support since 13. > I belive it will build on 12, but elf_aux_info will return an error and > leave execpath unmodified. If you need to support earlier versions then > I guess a __FreeBSD_version ifdef would be appropriate.
OK that works for me. Do you want to send a new patch or should I adapt yours ? If you have a 12 somewhere that would save me time to verify I don't mess up with the ifdefs, otherwise I can probably handle it and we'll watch for any report of build error. Thanks, Willy
