---------- Forwarded message --------- From: Anthony Doeraene <[email protected]> Date: Fri, Aug 30, 2024 at 3:32 PM Subject: Re: [PATCH v2 4/4] FEATURE: add MPTCP per address support To: Willy Tarreau <[email protected]>
> Otherwise let me know if I can apply it as-is. Seems good to me ! Thank you again for your reviews. > I'm very happy that after so long this topic has been alive, with your, > Matt's and Dorian's help we're finally reaching the end of the tunnel! Thank you also for being open to these changes ! The fact that haproxy should support soon MPTCP could encourage even more application developers to use it, as it becomes easier for them to enable it on the server side :D. For the anecdote, we had a debate with some application developers that lacked support for MPTCP in haproxy just 3 days ago, that should help them too ! Have a nice day, Doeraene Anthony On Fri, Aug 30, 2024 at 3:25 PM Willy Tarreau <[email protected]> wrote: > > On Mon, Aug 26, 2024 at 11:50:27AM +0200, Aperence wrote: > > diff --git a/src/backend.c b/src/backend.c > > index 6956d9bfe..e4bd465e9 100644 > > --- a/src/backend.c > > +++ b/src/backend.c > > @@ -1690,8 +1690,9 @@ int connect_server(struct stream *s) > > > > if (!srv_conn->xprt) { > > /* set the correct protocol on the output stream connector */ > > + > > if (srv) { > > - if (conn_prepare(srv_conn, > > protocol_lookup(srv_conn->dst->ss_family, PROTO_TYPE_STREAM, 0), > > srv->xprt)) { > > + if (conn_prepare(srv_conn, > > protocol_lookup(srv_conn->dst->ss_family, PROTO_TYPE_STREAM, > > srv->alt_proto), srv->xprt)) { > > conn_free(srv_conn); > > return SF_ERR_INTERNAL; > > } > > This one could have been left in a separate patch (like the 3/4) but as > we know that no other backend proto uses alt_proto right now, it really > has no impact. > > Nothing else to say for the rest of the series. It's clean and looks > sane. I'm ready to merge it. I'd just adjust the severity subject tags > (MINOR for the first 2 and MEDIUM for the last two I think), and change > one word in the previous patch's commit message as mentioned. > > If you have any last-minute change pending, feel free to suggest them > (I can apply them manually if they're trivial) or to resend the series. > Otherwise let me know if I can apply it as-is. > > I'm very happy that after so long this topic has been alive, with your, > Matt's and Dorian's help we're finally reaching the end of the tunnel! > > Thanks! > Willy
