On Thu, Apr 17, 2025 at 10:56:12PM +0200, Ilia Shipitsin wrote:
> Subject: [PATCH 01/10] CI: musl: enable unit tests
> Run the new make unit-tests on the CI.
> ---
> .github/workflows/musl.yml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/.github/workflows/musl.yml b/.github/workflows/musl.yml
> index a54414fab..b4d91e45a 100644
> --- a/.github/workflows/musl.yml
> +++ b/.github/workflows/musl.yml
> @@ -26,7 +26,7 @@ jobs:
> - name: Install VTest
> run: scripts/build-vtest.sh
> - name: Build
> - run: make -j$(nproc) TARGET=linux-musl ARCH_FLAGS='-ggdb3' CC=cc V=1
> USE_LUA=1 LUA_INC=/usr/include/lua5.3 LUA_LIB=/usr/lib/lua5.3 USE_OPENSSL=1
> USE_PCRE2=1 USE_PCRE2_JIT=1 USE_PROMEX=1
> + run: make -j$(nproc) TARGET=linux-musl DEBUG="-DDEBUG_POOL_INTEGRITY
> -DDEBUG_UNIT" ARCH_FLAGS='-ggdb3' CC=cc V=1 USE_LUA=1
> LUA_INC=/usr/include/lua5.3 LUA_LIB=/usr/lib/lua5.3 USE_OPENSSL=1 USE_PCRE2=1
> USE_PCRE2_JIT=1 USE_PROMEX=1
> - name: Show version
> run: ./haproxy -vv
> - name: Show linked libraries
> @@ -37,6 +37,10 @@ jobs:
> - name: Run VTest
> id: vtest
> run: make reg-tests VTEST_PROGRAM=../vtest/vtest
> REGTESTS_TYPES=default,bug,devel
> + - name: Run Unit tests
> + id: unittests
> + run: |
> + make unit-tests
> - name: Show coredumps
> if: ${{ failure() && steps.vtest.outcome == 'failure' }}
> run: |
Hello Ilia,
The unit-test ones lack the "Show Unit-Tests results" that we have in
vtest.yml, It would be better to have it to
display what's going on upon failure.
I wonder if we can't just inherit most of the steps instead of copying the same
yml part in every part, it would be less
difficult to maintain.
Regards,
--
William Lallemand
