Thanks, merged!

On Mon, Jul 07, 2025 at 08:55:32AM +0200, Илья Шипицин wrote:
> Subject: Re: [PATCH] CI: enable QUIC=1 if OpenSSL >= 3.5.0
> пн, 7 июл. 2025 г. в 08:25, William Lallemand <[email protected]>:
> 
> > Hello Ilia,
> >
> > Can you add a description to the patch?
> >
> > Thank you.
> >
> >
> > On Sun, Jul 06, 2025 at 06:03:34PM +0200, Ilia Shipitsin wrote:
> > > Subject: [PATCH] CI: enable QUIC=1 if OpenSSL >= 3.5.0
> > > ---
> > >  .github/matrix.py | 11 +++++++++--
> > >  1 file changed, 9 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/.github/matrix.py b/.github/matrix.py
> > > index efecb338f..996b79248 100755
> > > --- a/.github/matrix.py
> > > +++ b/.github/matrix.py
> > > @@ -232,8 +232,6 @@ def main(ref_name):
> > >
> > >          for ssl in ssl_versions:
> > >              flags = ["USE_OPENSSL=1"]
> > > -            if ssl == "BORINGSSL=yes" or ssl == "QUICTLS=yes" or
> > "LIBRESSL" in ssl or "WOLFSSL" in ssl or "AWS_LC" in ssl:
> > > -                flags.append("USE_QUIC=1")
> > >              if "WOLFSSL" in ssl:
> > >                  flags.append("USE_OPENSSL_WOLFSSL=1")
> > >              if "AWS_LC" in ssl:
> > > @@ -246,6 +244,15 @@ def main(ref_name):
> > >              if "OPENSSL" in ssl and "latest" in ssl:
> > >                  ssl = determine_latest_openssl(ssl)
> > >
> > > +            openssl_supports_quic = False
> > > +            try:
> > > +              openssl_supports_quic =
> > version.Version(ssl.split("OPENSSL_VERSION=",1)[1]) >=
> > version.Version("3.5.0")
> > > +            except:
> > > +              pass
> > > +
> > > +            if ssl == "BORINGSSL=yes" or ssl == "QUICTLS=yes" or
> > "LIBRESSL" in ssl or "WOLFSSL" in ssl or "AWS_LC" in ssl or
> > openssl_supports_quic:
> > > +                flags.append("USE_QUIC=1")
> > > +
> > >              matrix.append(
> > >                  {
> > >                      "name": "{}, {}, ssl={}".format(os, CC,
> > clean_ssl(ssl)),
> > > --
> > > 2.46.0.windows.1
> > >
> > >
> > >
> >
> > --
> > William Lallemand
> >

> From 00c5485936e0d18bce46dbbf64fbb2eb303b6117 Mon Sep 17 00:00:00 2001
> From: Ilia Shipitsin <[email protected]>
> Date: Mon, 7 Jul 2025 08:53:21 +0200
> Subject: [PATCH] CI: enable USE_QUIC=1 for OpenSSL versions >= 3.5.0
> 
> OpenSSL 3.5.0 introduced experimental support for QUIC. This change enables 
> the use_quic option when a compatible version of OpenSSL is detected, 
> allowing QUIC-based functionality to be leveraged where applicable. Feature 
> remains disabled for earlier versions to ensure compatibility.
> ---
>  .github/matrix.py | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/.github/matrix.py b/.github/matrix.py
> index efecb338f..996b79248 100755
> --- a/.github/matrix.py
> +++ b/.github/matrix.py
> @@ -232,8 +232,6 @@ def main(ref_name):
>  
>          for ssl in ssl_versions:
>              flags = ["USE_OPENSSL=1"]
> -            if ssl == "BORINGSSL=yes" or ssl == "QUICTLS=yes" or "LIBRESSL" 
> in ssl or "WOLFSSL" in ssl or "AWS_LC" in ssl:
> -                flags.append("USE_QUIC=1")
>              if "WOLFSSL" in ssl:
>                  flags.append("USE_OPENSSL_WOLFSSL=1")
>              if "AWS_LC" in ssl:
> @@ -246,6 +244,15 @@ def main(ref_name):
>              if "OPENSSL" in ssl and "latest" in ssl:
>                  ssl = determine_latest_openssl(ssl)
>  
> +            openssl_supports_quic = False
> +            try:
> +              openssl_supports_quic = 
> version.Version(ssl.split("OPENSSL_VERSION=",1)[1]) >= 
> version.Version("3.5.0")
> +            except:
> +              pass
> +
> +            if ssl == "BORINGSSL=yes" or ssl == "QUICTLS=yes" or "LIBRESSL" 
> in ssl or "WOLFSSL" in ssl or "AWS_LC" in ssl or openssl_supports_quic:
> +                flags.append("USE_QUIC=1")
> +
>              matrix.append(
>                  {
>                      "name": "{}, {}, ssl={}".format(os, CC, clean_ssl(ssl)),
> -- 
> 2.46.0.windows.1
> 


-- 
William Lallemand


Reply via email to