Hi Alexander, sorry for the delay.
On Fri, Aug 01, 2025 at 03:32:12PM +0000, Stephan, Alexander wrote: > Hi everyone, > > I just want to give a quick heads-up. I think there were some extra symbols > in the patch I provided earlier, I am really sorry. > This time, I just append the file to make sure the formatting is correct and > the email client doesn't do anything sketchy. Thanks! I can confirm it applied well. > I would be really glad about any feedback. Here is also the link to the > GitHub issue: https://github.com/haproxy/haproxy/issues/2915 > [https://opengraph.githubassets.com/f700e7a4ac91420ffee1e4e314dca7f69e7507a018d9eacc90018f27fbd84c66/haproxy/haproxy/issues/2915]<https://github.com/haproxy/haproxy/issues/2915> No particular comment to make on the patch, it looks fine as-is, and thank you for the reg-test! I was wondering if we shouldn't also have the le2hex() version since there's already be2hex(). We tend to have a lot of holes in the functions coverage because each of them are added by people who need them, and often users end up missing something, like here. If you feel like doing it as well, be my guest! I've added a reference to that issue in the commit message before applying it. I'm a bit sad by the way to see that your feature request didn't get any single comment. It happens sometimes. It's nice in the end that you wrote the patch! Thanks! Willy
