Hi Willy,

Thanks for the review! Glad you like the change. I appended the split-up 
patches.

Cheers,
Alexander

-----Original Message-----
From: Willy Tarreau <[email protected]> 
Sent: Friday, 29 August 2025 10:25
To: Stephan, Alexander <[email protected]>; Menges, Christian Norbert 
<[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] BUG/MINOR: Add missing NULL checks

Hi guys,

On Thu, Aug 28, 2025 at 12:35:31PM +0000, Stephan, Alexander wrote:
> Hi list,
> 
> My colleague Christian and I have added several missing null checks, 
> which we think should be there to improve robustness. We're looking 
> forward to your feedback on the attached patch.

That's really nice to deal with this, and I agree with all of your fixes. The 
only thing I'll ask you is to split it by subsystem, thus into multiple 
patches. This way we'll more easily refer to them later, as well as backport 
them to the relevant stable releases.

Thanks!
Willy

Attachment: 0006-BUG-MINOR-tools-Add-OOM-check-for-malloc-in-indent_m.patch
Description: 0006-BUG-MINOR-tools-Add-OOM-check-for-malloc-in-indent_m.patch

Attachment: 0005-BUG-MINOR-compression-Add-OOM-check-for-calloc-in-pa.patch
Description: 0005-BUG-MINOR-compression-Add-OOM-check-for-calloc-in-pa.patch

Attachment: 0004-BUG-MINOR-cfgparse-Add-OOM-check-for-calloc-in-cfg_p.patch
Description: 0004-BUG-MINOR-cfgparse-Add-OOM-check-for-calloc-in-cfg_p.patch

Attachment: 0003-BUG-MINOR-acl-Add-OOM-check-for-calloc-in-smp_fetch_.patch
Description: 0003-BUG-MINOR-acl-Add-OOM-check-for-calloc-in-smp_fetch_.patch

Attachment: 0002-BUG-MINOR-log-Add-OOM-checks-for-calloc-and-malloc-i.patch
Description: 0002-BUG-MINOR-log-Add-OOM-checks-for-calloc-and-malloc-i.patch

Attachment: 0001-BUG-MINOR-halog-Add-OOM-checks-for-calloc-in-filter_.patch
Description: 0001-BUG-MINOR-halog-Add-OOM-checks-for-calloc-in-filter_.patch

Reply via email to