On Fri Sep 5, 2025 at 8:56 AM CEST, Willy Tarreau wrote: > On Thu, Sep 04, 2025 at 09:19:39AM +0200, Maximilian Moehl wrote: >> This commit adds the base2 converter to turn binary input into it's >> string representation. Each input byte is converted into a series of >> eight characters which are either 0s and 1s by bit-wise comparison. >> --- >> Switched to bit-wise comparison instead of a lookup table as suggested by >> Willy. >> I was unsure whether the added run time would be an issue so I initially >> opted >> for the lookup table like it's done for hex, but it makes sense that this >> huge >> table could cause more issues. > > Thank you, it looks fine now and works as expected, I've merged it!
Thank you, is it possible to back-port this change to 3.2? We are currently preparing the upgrade to 3.2 and would prefer if we can stay on that version for some time. >> Last time I submitted an updated patch used the In-Reply-To header, but that >> seems to be discouraged for patches. Adding the v2 seems the preferred option >> so I did that now, hope this is the right way. > > There's not enough traffic on the list for this to matter that much. Yes > a v2 is easier to spot, but if in certain circumstances you prefer to > continue on the same thread, or just to attach the patch to the mail, > that's fine as well. What is more difficult to deal with is reviews with > many patches in a mail because usually they cannot be done all at once, > and it complicates the continuation. But even 2-3 small patches in a mail > once in a while is no big deal. Good to know. I also wanted to let you guys know that every interaction I had with the HAProxy community over the past years has been very pleasent. Keep up the good work! -- Max
