Hi Willy, Long time no see since I was too busy for my job.. Happy New Year :)
I've implemented and changed some code lines based on feedback from what you said. Please check and give me more comments about it. (I didn't get used to email-based commit yet,,please tell me if there are any wrong commit or contribs too) Sincerely, Hyeonggeun Oh. On Sun, Nov 16, 2025 at 10:24 PM Hyeonggeun Oh <[email protected]> wrote: > Hi Willy. > > Thanks for your kindness. > With your technical comments, it seems like it will take some time to fix > my patches. > It also includes more detailed and deep study about haproxy source code > (for my cleaner implementations of further features!) > > And as you said, the more important thing than adding features in 3.3 is > to make good patches to avoid additional fixes. > I'll study a few more days and will be back with new clean patches (i hope > so). > Thanks for your advice. > > Sincerely, > Hyeonggeun. > > On Sun, Nov 16, 2025 at 5:31 AM Willy Tarreau <[email protected]> wrote: > >> Hi Hyeonggeun, >> >> On Sat, Nov 15, 2025 at 10:52:10PM +0900, Hyeonggeun Oh wrote: >> > Hi Willy. >> > >> > Thanks for your very detailed comments. >> > I think I can check and implement what you've said by tomorrow. >> > >> > While it would be cleaner to quickly fix the changes and include >> everything >> > in 3.3, >> > since this is my first contribution and I respect the maintainer's >> opinion, >> > I have no major objection to the feature being included in the next >> patch. >> > >> > Alternatively, as you suggested, applying only the first patch to 3.3 >> > first, then refining this feature more cleanly and backporting it is >> also a >> > good approach. >> > For now, I will submit the correct fix ASAP. >> > Please review and decide afterward. >> >> OK thank you! Don't pressure yourself. I know it's super tempting to >> get a first contribution merged, but you'll feel relieved once it's >> merged anyway, and it will be even better if we don't have to fix it >> afterwards due to a rushed patch :-) >> >> cheers, >> Willy >> >
