Re: [PATCH] CLEANUP: mux-h1: Remove unneeded null check

[Christopher Faulet]

Le 18/02/2026 à 3:43 PM, Egor Shestakov a écrit :

Since 3.1 a task is always created when H1 connections initialize, so
the later null check before task_queue() became unneeded.

Could be backported with 3c09b3432 (BUG/MEDIUM: mux-h1: Fix how timeouts
are applied on H1 connections).
---
  src/mux_h1.c | 8 +++-----
  1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/mux_h1.c b/src/mux_h1.c
index bdb461237..430ff0da1 100644
--- a/src/mux_h1.c
+++ b/src/mux_h1.c
@@ -1371,11 +1371,9 @@ static int h1_init(struct connection *conn, struct proxy 
*proxy, struct session
                            H1_EV_H1C_NEW|H1_EV_STRM_NEW, h1c->conn, h1c->h1s);
        }

- if (t) {

-               h1_set_idle_expiration(h1c);
-               t->expire = tick_first(t->expire, h1c->idle_exp);
-               task_queue(t);
-       }
+       h1_set_idle_expiration(h1c);
+       t->expire = tick_first(t->expire, h1c->idle_exp);
+       task_queue(t);

/* prepare to read something */

        if (b_data(&h1c->ibuf))

Thanks, now merged.

--
Christopher