On Fri, Apr 03, 2026 at 11:29:02PM +0200, Tim Duesterhus wrote:
> The purpose of this field is the same as the one in `struct stream`.
> 
> Reviewed-by: Volker Dusch <[email protected]>

This one needs a bit more explanation. It's super hard during a review
(and even later when revisiting a patch) to get a "redirect" in a
commit message basically saying "same as another one". I should be able
to figure when reading the patch and the commit message whether it looks
good or not without having to look for a field in another structure and
try to figure what it's used for. Without entering into details, please
just say a few words about the intent here.
 
Note, you can just reply with a few lines and I'll paste them myself.

Thanks!
Willy


Reply via email to