On Mon, Apr 13, 2026 at 04:29:01PM +0000, Egor Shestakov wrote:
> Subject: [PATCH] BUG/MINOR: acme: don't pass NULL into format string
> Printing a "(null)" when NULL passed with the %s format specifier is a
> GNU extension, so it must be avoided for portability reasons.
>
> Must be backported as far as 3.2
> ---
> src/acme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acme.c b/src/acme.c
> index 437528c08..18b5b2c17 100644
> --- a/src/acme.c
> +++ b/src/acme.c
> @@ -800,7 +800,7 @@ static int cfg_postsection_acme()
> /* tries to open the account key */
> if (stat(path, &st) == 0) {
> if (ssl_sock_load_key_into_ckch(path, NULL, store->data,
> &errmsg)) {
> - memprintf(&errmsg, "%s'%s' is present but cannot be
> read or parsed.\n", errmsg, path);
> + memprintf(&errmsg, "%s'%s' is present but cannot be
> read or parsed.\n", errmsg ? errmsg : "", path);
> if (errmsg)
> indent_msg(&errmsg, 8);
> err_code |= ERR_ALERT | ERR_FATAL | ERR_ABORT;
> --
> Egor Shestakov
> egor ascii(0x40) ved1 ascii(0x2E) me
Merged, thanks.
--
William Lallemand
