Hi On 4/13/26 11:54, Willy Tarreau wrote:
While I'm fine with the cleanup, I'm not fond of systematically adding one function call to retrieve a pointer. How about this almost identical but cheaper variant?
I specifically wanted to avoid relying on the "internal knowledge" of the `stream_generate_unique_id()` function here to keep complexity low.
I've looked into extracting the actual generation logic into a dedicated function (which would also avoid some duplicating with `check_generate_unique_id()`) and then making the `stream_generate_unique_id()` inlineable, such that the compiler can see the `s->unique_id` field access, but that resulted in some messy header dependencies
I'll send the updated series once I'm doing testing, but if you don't like it, you can take this patch (v2 5/9) with your suggested change. It's still an improvement over the existing situation.
Best regards Tim Düsterhus
